Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autofix to media-feature-parentheses-space-inside #3720

Merged
merged 4 commits into from Oct 17, 2018
Merged

Add autofix to media-feature-parentheses-space-inside #3720

merged 4 commits into from Oct 17, 2018

Conversation

yepninja
Copy link
Member

@yepninja
Copy link
Member Author

I had to fix snapshots. Now the order of the errors is more correct.

jeddy3
jeddy3 requested changes Oct 17, 2018
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yepninja This is looking fab! Thanks a lot. It's great to see the value parser being put to use.

I've made one very minor request to do with the name of a variable, otherwise this LGTM.

lib/rules/media-feature-parentheses-space-inside/index.js Outdated
@@ -31,50 +31,62 @@ const rule = function(expectation) {
// will be at atRule.raws.params.raw
const params = _.get(atRule, "raws.params.raw", atRule.params);
const indexBoost = atRuleParamIndex(atRule);
const errors = [];
Copy link
Member

@jeddy3 jeddy3 Oct 17, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this to violations, please?

It's a convention we've adopted to:

  • help distinguish between things caught by the linter and actual errors, for example those thrown by the parsers.
  • act as an intermediary before those things are categorised into a particular severity e.g. "error" or "warning".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. No problem at all.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@jeddy3 jeddy3 changed the title Add autofix to rule media-feature-parentheses-space-inside Add autofix to media-feature-parentheses-space-inside Oct 17, 2018
@jeddy3 jeddy3 mentioned this pull request Oct 17, 2018
Merged
vankop
vankop requested changes Oct 17, 2018
View reviewed changes
Copy link
Member

@vankop vankop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yepninja I have added small suggestion.

lib/rules/media-feature-parentheses-space-inside/index.js Outdated Show resolved Hide resolved
jeddy3
jeddy3 approved these changes Oct 17, 2018
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yepninja Thanks for making the change. LGTM.

@jeddy3 jeddy3 merged commit 0180dc5 into stylelint:master Oct 17, 2018
@jeddy3
Copy link
Member

jeddy3 commented Oct 17, 2018

  • Added: media-feature-parentheses-space-inside autofix (#3720).

@alexander-akait alexander-akait mentioned this pull request Oct 17, 2018
Closed
This was referenced Oct 28, 2018
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Sep 23, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

@vankop vankop vankop approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yepninja @jeddy3 @vankop